Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelconsumer: remove temporary handling of entity too large #41911

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Dec 5, 2024

Proposed commit message

This code was initially added in #41523 because of a limitation from the elasticsearch exporter.

The elasticsearch exporter has been updated to enforce flush::bytes for the batcher extension and will automatically split the batch if it exceeds the limit.

This error is now fixed in the collector v0.115.0.

See open-telemetry/opentelemetry-collector-contrib#36396.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

This code was initially added in elastic#41523 because of a limitation from the
elasticsearch exporter.

The elasticsearch exporter has been updated to enforce flush::max_bytes
for the batcher extension and will automatically split the batch if it
exceeds the limit.

This error is now fixed in the collector v0.115.0.

See open-telemetry/opentelemetry-collector-contrib#36396.
@mauri870 mauri870 added cleanup backport-8.x Automated backport to the 8.x branch with mergify labels Dec 5, 2024
@mauri870 mauri870 self-assigned this Dec 5, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 5, 2024
@mauri870 mauri870 marked this pull request as ready for review December 5, 2024 14:09
@mauri870 mauri870 requested a review from a team as a code owner December 5, 2024 14:09
@mauri870 mauri870 requested review from faec and VihasMakwana December 5, 2024 14:09
@mauri870 mauri870 requested a review from leehinman December 9, 2024 11:17
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As a follow on to this PR, can you add an integration test to the elastic-agent repo that proves that large batches get split? I want to be sure that we have a test somewhere that proves that batch splitting works.

@mauri870
Copy link
Member Author

As a follow on to this PR, can you add an integration test to the elastic-agent repo that proves that large batches get split? I want to be sure that we have a test somewhere that proves that batch splitting works.

Agree, we should have a test for this. I added to the notes in the original issue and will follow up on it.

@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 merged commit dbeb9cd into elastic:main Dec 10, 2024
141 checks passed
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
This code was initially added in #41523 because of a limitation from the
elasticsearch exporter.

The elasticsearch exporter has been updated to enforce flush::max_bytes
for the batcher extension and will automatically split the batch if it
exceeds the limit.

This error is now fixed in the collector v0.115.0.

See open-telemetry/opentelemetry-collector-contrib#36396.

(cherry picked from commit dbeb9cd)
mauri870 added a commit that referenced this pull request Dec 10, 2024
…41971)

This code was initially added in #41523 because of a limitation from the
elasticsearch exporter.

The elasticsearch exporter has been updated to enforce flush::max_bytes
for the batcher extension and will automatically split the batch if it
exceeds the limit.

This error is now fixed in the collector v0.115.0.

See open-telemetry/opentelemetry-collector-contrib#36396.

(cherry picked from commit dbeb9cd)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Dec 13, 2024
…41911)

This code was initially added in elastic#41523 because of a limitation from the
elasticsearch exporter.

The elasticsearch exporter has been updated to enforce flush::max_bytes
for the batcher extension and will automatically split the batch if it
exceeds the limit.

This error is now fixed in the collector v0.115.0.

See open-telemetry/opentelemetry-collector-contrib#36396.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants